[PATCH] D51433: [InstCombine] enhance vector demanded elements to look at a vector select condition operand

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 10 10:26:59 PDT 2018


craig.topper added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp:1263
   case Instruction::Select: {
+    // If this is a vector select, try to transform the select condition based
+    // on the current demanded elements.
----------------
What would you think about casting to SelectInst and using getCondition, getTrueValue, getFalseValue, setCondition, etc. throughout this code?


https://reviews.llvm.org/D51433





More information about the llvm-commits mailing list