[PATCH] D51836: [bugpoint] Fix TempFile scoping bug

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 10 08:56:27 PDT 2018


Meinersbur added inline comments.


================
Comment at: tools/bugpoint/ExecutionDriver.cpp:439
   Expected<std::string> Output =
       executeProgram(Program, "", BitcodeFile, SharedObject, nullptr);
   if (Error E = Output.takeError())
----------------
[serious] Here is another call to `executeProgram`. `BitcodeFile` can be empty as well (e.g. `BugDriver.cpp:218`) which will fail if only `executeProgramSafely` handles creating the bitcode file.


Repository:
  rL LLVM

https://reviews.llvm.org/D51836





More information about the llvm-commits mailing list