[PATCH] D51574: [LiveRangeCalc] Fixed findReachingDefs bug

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

Hi Tim,

The change itself looks good to me, but the testcase is not specific enough to bring value. In particular, we shouldn't require to build with assert to see the problem/correct behavior.

Cheers,
-Quentin



================
Comment at: test/CodeGen/AMDGPU/regcoalescer-assert-from-incorrect-subrange-extension.mir:2
+# RUN: llc -march=amdgcn -run-pass simple-register-coalescing -o - %s | FileCheck --check-prefix=GCN %s
+# REQUIRES: asserts
+#
----------------
Could you check that the coalescing does the right thing instead of just checking that we emit a function?


================
Comment at: test/CodeGen/AMDGPU/regcoalescer-assert-from-incorrect-subrange-extension.mir:52
+  savePoint:       ''
+  restorePoint:    ''
+fixedStack:      
----------------
At this point I don't think the frameInfo is relevant.
Could you rip it off?

Tip: You can use -simplify-mir when you create your .mir file to get rid of this kind of cruft.


Repository:
  rL LLVM

https://reviews.llvm.org/D51574