[PATCH] D50598: LLD COFF: Add support for /force:multiple option

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: COFF/SymbolTable.cpp:329
 void SymbolTable::reportDuplicate(Symbol *Existing, InputFile *NewFile) {
-  error("duplicate symbol: " + toString(*Existing) + " in " +
-        toString(Existing->getFile()) + " and in " + toString(NewFile));
+  auto message = "duplicate symbol: " + toString(*Existing) + " in " +
+                 toString(Existing->getFile()) + " and in " +
----------------
We don't use `auto` unless an actual type is obvious:

  auto -> std::string

Variable names should start with an uppercase letter and should be concise:

  message -> Msg





Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D50598