[PATCH] D51550: Use alias analysis to check for real interference in cascade comparison

[Clement Courbet via Phabricator via llvm-commits]

courbet added a comment.

Thanks for the patch Christy !



================
Comment at: lib/Transforms/Scalar/MergeICmps.cpp:190
+    MemoryLocation RLoc = MemoryLocation::get(Rhs_.LoadI);
+    if (isModSet(AA->getModRefInfo(Inst, LLoc)) ||
+        isModSet(AA->getModRefInfo(Inst, RLoc)))
----------------
What about instructions that do not write to memory but may throw ?


================
Comment at: test/Transforms/MergeICmps/X86/alias-merge-blocks.ll:10
+;
+; Make sure this call is moved to the beginning of the entry block.
+; X86:      entry:
----------------
It's not clear what "this call" refers to.


Repository:
  rL LLVM

https://reviews.llvm.org/D51550