[PATCH] D25987: [X86] New pattern to generate PSUBUS from SELECT

[Yulia Koval via Phabricator via llvm-commits]

yulia_koval added a comment.

> What does this comment in InstCombineSelect refer to?

/// TODO: Also support a - UMIN(a,b) patterns.

This was a todo to investigate possibilities for generating min patterns, but seems like all of them are already handled, so we can just remove this TODO.

> Also, there's a proposal to remove the intrinsics now - https://reviews.llvm.org/D44785. How does that relate to whatever is left to do here?

This is already commited, I think. This was converting intrinsics to cannonical form.

> It seems to continue in https://reviews.llvm.org/D33118. Mentioning it so Phabricator makes the link.

This is old version of same revision, abandoned it.

> @yulia_koval Are you still working on this?

No, I think this issue is finished..


https://reviews.llvm.org/D25987