[PATCH] D51695: [MC] [AsmParser]: Ensure a new CFI frame is not opened within an existing one when using cc1as (causing a crash due to failed assert).

[Kristina Brooks via Phabricator via llvm-commits]

kristina added a comment.

This is a testcase for the crash, patch fixes it, though I'll amend it to work on MCStreamer level as per what @rnk suggested. I'm going to sound really stupid asking but where should the testcase be, is it a FileCheck based one? I just made two targets, one with pre-patch toolchain and one with current (my working tree) toolchain which handles this just fine. First one crashes, second one doesn't, not sure where tests like that go.

  #if !defined(__x86_64__)
  	#error Unsupported architecture
  #endif   
  
  .align 2, 0x90
  .type Cfi_level_0, @function
  .global Cfi_level_0
  .hidden Cfi_level_0
  .cfi_startproc
  Cfi_level_0:
  	movq $123, %rax
  	ret
  
  .align 2, 0x90
  .type Cfi_level_1, @function
  .global Cfi_level_1
  .hidden Cfi_level_1
  .cfi_startproc
  Cfi_level_1:
  	movq $321, %rax
  	int  $3
  
  .cfi_endproc; .size Cfi_level_0, . - Cfi_level_0


Repository:
  rL LLVM

https://reviews.llvm.org/D51695