[PATCH] D51837: Move a transformation routine from LoopUtils to LoopVectorize.

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

Sounds good to me. WIth some optional nits.



================
Comment at: Transforms/Vectorize/LoopVectorize.cpp:2808
 
+Value *InnerLoopVectorizer::emitTransformedIndex(IRBuilder<> &B, Value *Index,
+                                         ScalarEvolution *SE,
----------------
Nit: does this need a clang-format?


================
Comment at: Transforms/Vectorize/LoopVectorize.cpp:2850
+    assert(Step->getType()->isFloatingPointTy() && "Expected FP Step value");
+    auto InductionBinOp = ID.getInductionBinOp();
+    assert(InductionBinOp &&
----------------
Nit: I tend to avoid auto in lines that don't already make the type obvious. This is just me though, so feel free to ignore.


Repository:
  rL LLVM

https://reviews.llvm.org/D51837