[PATCH] D51835: [ADT] Support converting to lowercase string in toHex
Kristina Brooks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Sep 9 09:00:40 PDT 2018
kristina added a comment.
LGTM.
(Really nit-picky comment: I would have done it by keeping an offset aside to add for lower case `A-F` to `a-f` and kept the original table as is. Implications of removing `static` may cause an insignificant increase in code size with bad linkers, just speculating, feel free to ignore)
Repository:
rL LLVM
https://reviews.llvm.org/D51835
More information about the llvm-commits
mailing list