[PATCH] D51552: Libraries added with add_llvm_loadable_module macro to have their component name
Valeriy Dmitriev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 7 17:49:07 PDT 2018
vdmitrie added a comment.
In https://reviews.llvm.org/D51552#1228072, @tstellar wrote:
> I've just updated the patch with some fixes, can you try again?
The latest patch version seems to work fine. Thanks!
May suggest you to not guard against creating install target for MODULE? (if it does not create any problem)
if (NOT CMAKE_CONFIGURATION_TYPES)
add_llvm_install_targets(install-${name}
DEPENDS ${name}
COMPONENT ${name})
endif()
Repository:
rL LLVM
https://reviews.llvm.org/D51552
More information about the llvm-commits
mailing list