[PATCH] D51246: Common infrastructure for reading a profile remapping file and building a mangling remapper from it.

Richard Smith - zygoloid via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 7 16:09:50 PDT 2018


rsmith added a comment.

In https://reviews.llvm.org/D51246#1219437, @davidxl wrote:

> Perhaps add some test cases for the parser and reader?


Sure. (This was intended to be committed with users of this functionality, which have their own tests, but testing the parse errors seems like a good idea.)



================
Comment at: include/llvm/Support/SymbolRemappingReader.h:34
+//  * type  A <type>, such as Ss or N4llvm9StringRefE
+//  * encoding  An <encoding> (a complete mangling without the leading _Z)
+//
----------------
davidxl wrote:
> what is the difference between name and encoding? Can you add an encoding example?
An <encoding> allows you to reference a particular overload of a function or a particular specialization of a function template. Remapping a <name> would instead always remap an entire overload set. Example added.


Repository:
  rL LLVM

https://reviews.llvm.org/D51246





More information about the llvm-commits mailing list