[llvm] r341706 - [AArch64] Support reserving x1-7 registers.

[Friedman, Eli via llvm-commits]

On 9/7/2018 2:42 PM, Nick Desaulniers via llvm-commits wrote:
> On Fri, Sep 7, 2018 at 2:36 PM Stephen Hines <srhines at google.com> wrote:
>> Thanks to Tri, who was the actual author of this patch (and the reviewers for their helpful comments too). The authorship information was mistakenly was omitted from the commit message. git-svn is misleading sometimes.
> Yes, I'm extremely sorry to Tri.  I was following
> https://llvm.org/docs/Phabricator.html#git-svn-and-arcanist:
>
> $ git checkout master && git pull
> $ arc patch D48580
> $ git rebase master
> $ git checkout master
> $ git merge --ff-only arcpatch-D48580
> $ git commit --amend --author="Tri Vo <trong at google.com>"
> $ git svn dcommit
>
> But then this seems to have pushed a commit with me as the author.
> Was there a correct way to do what I was trying to do (maintain
> authorship)?

SVN doesn't doesn't have separate author and committer fields.  So the 
rule is that you attribute patches by writing "patch by" in the commit 
message.

-Eli

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project