[PATCH] D51552: Libraries added with add_llvm_loadable_module macro to have their component name

[Valeriy Dmitriev via Phabricator via llvm-commits]

vdmitrie added a comment.

In https://reviews.llvm.org/D51552#1227797, @tstellar wrote:

> https://reviews.llvm.org/D51748 proposes refactoring this whole function and effectively makes the same change.  Would you be able to test this to see if it helps your uses case?


Unfortunately the patch "as is" failed at makefiles generation (cmake -G "Unix Makefiles" ...) with number of error messages like one below:
CMake Error at cmake/modules/LLVM-Config.cmake:105 (target_link_libraries):

  Target "LLVMHello" of type MODULE_LIBRARY may not be linked into another
  target.  One may link only to STATIC or SHARED libraries, or to executables
  with the ENABLE_EXPORTS property set.

Call Stack (most recent call first):

  cmake/modules/LLVM-Config.cmake:93 (explicit_llvm_config)
  cmake/modules/AddLLVM.cmake:750 (llvm_config)
  cmake/modules/AddLLVM.cmake:887 (add_llvm_executable)
  examples/Kaleidoscope/CMakeLists.txt:6 (add_llvm_example)
  examples/Kaleidoscope/Chapter8/CMakeLists.txt:5 (add_kaleidoscope_chapter)


Repository:
  rL LLVM

https://reviews.llvm.org/D51552