[PATCH] D51472: [ARM] Fix correctness checks in promoteToConstantPool.

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

Constant Island pass has a bit of a reputation for being the source of difficult bugs. With enough Mir testing, perhaps that doesn't need to be the case though. The general idea of turning the adr's into ldr's seems like a good one, maybe it just needs some better machinary in the pass to handle the pool entries more easily?

This here looks like two separate changes, both of which look fine to me.


Repository:
  rL LLVM

https://reviews.llvm.org/D51472