[PATCH] D44077: Clear the stack protector after checking it

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added subscribers: etienneb, timshen, rnk.
eugenis added a comment.

This looks fine to me in general. @timshen @etienneb @rnk

Please do the same thing in SDAG stack protector, otherwise you are missing some random configurations like glibc on aarch64, or arm32 on android.
Please add tests.



================
Comment at: lib/CodeGen/SafeStack.cpp:464
+  // Zero the protector after it was checked to prohibit leaks.
+  IRB.CreateStore(ConstantPointerNull::get(GuardPtrType), StackGuardSlot, true);
 
----------------
Add a comment /*isVolatile*/ here and below.



Repository:
  rL LLVM

https://reviews.llvm.org/D44077