[PATCH] D51561: [CMake] Add support for unittests that have input files

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

In https://reviews.llvm.org/D51561#1226583, @zturner wrote:

> These aren't demangle tests fwiw.  But that just complicates the cmake
>  logic, and I don't see the benefit of doing so.  Writing 3k of data to the
>  disk is hardly going to be a noticeable part of the configure step.


The benefits are:

1. Unit tests reading inputs are bad form; doing that should require an explicit opt-in.

2. While writing 3k of data to disk isn't causing measurable perf issues, writing a text file next to every test binary just because one test binary needs it is still plain ugly.

And not doing it is super easy to do. I don't understand the pushback here.


Repository:
  rL LLVM

https://reviews.llvm.org/D51561