[PATCH] D51763: Remove addBlockByrefAddress(), it is dead code as far as clang is concerned.

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:981-982
     addComplexAddress(DV, Die, dwarf::DW_AT_location, Location);
-  else if (DV.isBlockByrefVariable())
-    addBlockByrefAddress(DV, Die, dwarf::DW_AT_location, Location);
   else
----------------
dblaikie wrote:
> Should this then be an assertion? And possibly a verifier check?
It's already part of the assertion on line 977; if it doesn't have a complex expression, then isBlockByrefVariable has to be false. Verifier check sounds reasonable.


https://reviews.llvm.org/D51763