[PATCH] D51770: [IndVars] Set Changed when we delete dead instructions. PR38855

[Serguei Katkov via Phabricator via llvm-commits]

skatkov added inline comments.


================
Comment at: lib/Transforms/Scalar/IndVarSimplify.cpp:2494
+            dyn_cast_or_null<Instruction>(DeadInsts.pop_back_val())) {
+      Changed = true;
       RecursivelyDeleteTriviallyDeadInstructions(Inst, TLI);
----------------
Changed |= ...?
RecursivelyDeleteTriviallyDeadInstructions may return false indicating that it did not remove anything...


================
Comment at: lib/Transforms/Scalar/IndVarSimplify.cpp:2502
   // loop may be sunk below the loop to reduce register pressure.
   sinkUnusedInvariants(L);
 
----------------
should it be fixed as well? And other places?


https://reviews.llvm.org/D51770