[PATCH] D51715: [LICM] Avoid duplicate work during building AliasSetTracker

[Serguei Katkov via Phabricator via llvm-commits]

skatkov added inline comments.


================
Comment at: lib/Transforms/Scalar/LICM.cpp:1559
     if (CurAST) {
       // What if InnerLoop was modified by other passes ?
       // Once we've incorporated the inner loop's AST into ours, we don't need
----------------
Actually this comment worries me most. What if another loop pass executing in the same LoopPassManager modifies the inner loop in the way that AST is changed?
If it is possible then removing the caching entirely is most safe thing to do probably.


https://reviews.llvm.org/D51715