[PATCH] D51717: [EarlyCSEwMemorySSA] Fix failure (w/ expensive checks). Need to resetOptimizeUses for replaced instructions.

George Burgess IV via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 6 16:55:22 PDT 2018


george.burgess.iv added inline comments.


================
Comment at: lib/Transforms/Scalar/EarlyCSE.cpp:607
       return;
+    if (VerifyMemorySSA)
+      MSSA->verifyMemorySSA();
----------------
george.burgess.iv wrote:
> Are these part of the fix? :)
(Oh, now I see the -verify-memoryssa in tests. Is there an easy way to mark the tests as unsupported if assertions aren't enabled? If we're relying on -verify-memoryssa to do everything, and -verify-memoryssa does nothing if assertions are off, ...)


Repository:
  rL LLVM

https://reviews.llvm.org/D51717





More information about the llvm-commits mailing list