[PATCH] D51748: cmake: Refactor add_llvm_loadable_module()
Philip Pfaffe via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 6 15:03:52 PDT 2018
philip.pfaffe added inline comments.
================
Comment at: cmake/modules/AddLLVM.cmake:677
+ add_llvm_library(${name} MODULE ${ARGN})
if(NOT TARGET ${name})
# Add empty "phony" target
----------------
beanz wrote:
> I don't believe there is any situation where calling add_llvm_library with `MODULE` would ever result in not creating the target, so this condition is probably not needed, which makes me think we should probably just get rid of `add_llvm_loadable_module` entirely.
Looks like it won't be created if(NOT LLVM_ENABLE_PLUGINS AND NOT (ARG_PLUGIN_TOOL AND LLVM_EXPORT_SYMBOLS_FOR_PLUGINS))
Repository:
rL LLVM
https://reviews.llvm.org/D51748
More information about the llvm-commits
mailing list