[PATCH] D51443: [dsymutil] Remove non-determinism.

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 6 14:32:33 PDT 2018


JDevlieghere added a comment.

In https://reviews.llvm.org/D51443#1226190, @aprantl wrote:

> > Yup. Why would -j1 generate different output? With this patch it's actually the other way around, we used to generate different output without threading, but now we do the same thing in both cases because we use the offset which is computed before.
>
> I discussed this with Fred and that was a misunderstanding on my end. On the flipside this also means that it isn't clear that -j1 actually uses less memory. Did you confirm that that's the case?


Jup, it definitely uses less memory (see the other differential for the actual values) but it’s not an order of magnitude. After talking with Fred we decided to remove the mention of it in the man page to avoid confusion.


https://reviews.llvm.org/D51443





More information about the llvm-commits mailing list