[PATCH] D51472: [ARM] Fix correctness checks in promoteToConstantPool.

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

Hello. Good to see this getting some love.

Sorry for the delay. I wanted to get https://reviews.llvm.org/D51410 in and see check what affect these had on performance. (And I've been busy with the regressions we've had come in lately). Results look good, although there's still some 16 byte alignment cases I need to look into.

Did you ever see https://reviews.llvm.org/D36787? It's almost certainly not worth looking at very much. I remember it being a bit over-complicated with constant pool entries pointing to other constant pool entries. If it helps, feel free to take what might be useful. I'm kind of hoping there is a better way than that though.

I will try and stare more closely at this tomorrow, if noone else takes a look earlier.


Repository:
  rL LLVM

https://reviews.llvm.org/D51472