[PATCH] D51561: [CMake] Add support for unittests that have input files

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 6 12:55:06 PDT 2018


MaskRay added a comment.

In https://reviews.llvm.org/D51561#1225458, @zturner wrote:

> I think LLVMTestingSupport should never be a shared lib, what do you think?


I don't know much about this target... just came across the build issue (`ninja` without arguments builds all (or most) targets). Pushed a quick fix https://reviews.llvm.org/rL341580 and waiting for your proper one :)

> I can’t fix this until tomorrow but if you need an immediate workaround you
>  can pass TestMainArgv0 to the function instead. Could you please check that
>  in for me?


Repository:
  rL LLVM

https://reviews.llvm.org/D51561





More information about the llvm-commits mailing list