[PATCH] D51561: [CMake] Add support for unittests that have input files

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 6 11:07:36 PDT 2018


thakis added a comment.

Sorry, didn't see this earlier. Writing a llvm.srcdir.txt next to every single unit test binary seems like a pretty roundabout way of doing this. How about instead passing the src dir in a runtime flag in http://llvm-cs.pcc.me.uk/utils/lit/lit/formats/googletest.py#107 if the lit config asks for it? Then you don't need to touch the disk to get the src dir path, it's not passed to _all_ binaries, and cmake doesn't have to write a file to disk for every test binary.


Repository:
  rL LLVM

https://reviews.llvm.org/D51561





More information about the llvm-commits mailing list