[PATCH] D51683: Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89

James Greenhalgh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 6 07:51:30 PDT 2018


jgreenhalgh added inline comments.


================
Comment at: cfe/trunk/utils/TableGen/NeonEmitter.cpp:2412
 
-  OS << "#define __ai static inline __attribute__((__always_inline__, "
+  OS << "#define __ai static __inline __attribute__((__always_inline__, "
         "__nodebug__))\n\n";
----------------
dnsampaio wrote:
> joerg wrote:
> > If you want to change it, at least change it properly to use __inline__.
> Sorry, I don't get the suggestion. Do you mean test if it is C89 and use __inline, else, use inline?
I think the suggestion was unintentionally rendered as an underline by phab; and was supposed to be 
```
__inline__
```


https://reviews.llvm.org/D51683





More information about the llvm-commits mailing list