[PATCH] D51169: [NewGVN] Mark function as changed if we erase instructions.

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope accepted this revision.
bjope added a comment.
This revision is now accepted and ready to land.

An alternative could perhaps be to do something like this

  Changed |= !InstructionsToErase.empty();

before the loop (assuming that if we got something in InstructionsToErase then we also have done some modifications).
But I think your solution (setting Changed whenever we do a change) is easier to understand.

Thanks for the patch. LGTM!


https://reviews.llvm.org/D51169