[PATCH] D51673: [XRay] Add a BlockIndexer visitor for FDR Records.

[Marcus Boerger via Phabricator via llvm-commits]

mboerger added a reviewer: mboerger.
mboerger accepted this revision.
mboerger added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/XRay/BlockIndexer.cpp:74
+  CurrentBlock.Records.push_back(&R);
+  CurrentState = State::SeekExtents;
+  return Error::success();
----------------
Decide for an order and be consistent.


================
Comment at: llvm/unittests/XRay/FDRBlockIndexerTest.cpp:65
+  ASSERT_THAT(T1Blocks, Not(Eq(Index.end())));
+  ASSERT_THAT(T1Blocks->second.size(), Eq(2u));
+
----------------
consider SizeIs() matcher.


================
Comment at: llvm/unittests/XRay/FDRBlockIndexerTest.cpp:72
+  ASSERT_THAT(T2Blocks, Not(Eq(Index.end())));
+  ASSERT_THAT(T2Blocks->second.size(), Eq(1u));
+  EXPECT_THAT(T2Blocks->second[0].Records.size(), Eq(6u));
----------------
consider using just ElementsAre() matcher without the assertion first.


https://reviews.llvm.org/D51673