[PATCH] D51706: ARM64: improve non-zero memset isel by ~2x

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 5 17:44:47 PDT 2018


efriedma added inline comments.


================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:8347
+  bool CanUseFP =
+      Subtarget->hasFPARMv8() && !F.hasFnAttribute(Attribute::NoImplicitFloat);
+  // Only use AdvSIMD to implement memset of 32-byte and above. It would have
----------------
Err, just realized one minor thing; technically, I guess you're supposed to check hasNEON() for v2i64, not hasFPARMv8().  Not really a big deal, though; they're essentially the same in practice.


Repository:
  rL LLVM

https://reviews.llvm.org/D51706





More information about the llvm-commits mailing list