[PATCH] D51707: [llvm-dwp] Use buffer_stream if output file is not seekable (e.g. "-")

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 5 16:56:04 PDT 2018


dblaikie accepted this revision.
dblaikie added inline comments.
This revision is now accepted and ready to land.


================
Comment at: tools/llvm-dwp/llvm-dwp.cpp:707
+  } else {
+    BOS = make_unique<buffer_ostream>(OutFile);
+    OS = BOS.get();
----------------
Could use Optional<buffer_ostream> here to save an extra allocation?


Repository:
  rL LLVM

https://reviews.llvm.org/D51707





More information about the llvm-commits mailing list