[PATCH] D51648: [UBSan] Partially fix `test/ubsan/TestCases/Misc/log-path_test.cc` so that it can run on devices.

[Filipe Cabecinhas via Phabricator via llvm-commits]

filcab added a comment.

In https://reviews.llvm.org/D51648#1225124, @george.karpenkov wrote:

> >   To run just-built programs for tests. Not to run anything else
>
> What? Why? 
>  How else can you run commands on the device (cat/cp/rm/etc) and why the semantics of those is different?
>  Many sanitizer tests already need those commands (e.g. this was recently done for libFuzzer to support device integration)


Most lit commands are run on the host. The `%run` substitution is there for exactly that: "Take this just-built target executable and run it with these args".
All the cat/rm/etc commands are run on the host, as expected.

>> most will have a shell anyway
> 
> Yes, and having a shell seems to be a basic requirement for running LIT tests anyway.

lit tests run on the host, not the target.

>> I don't like forcing other platforms to do the same.
> 
> Where is this patch forcing other platforms?

The test is a general ubsan test.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D51648