[PATCH] D51648: [UBSan] Partially fix `test/ubsan/TestCases/Misc/log-path_test.cc` so that it can run on devices.

George Karpenkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 5 12:05:16 PDT 2018


george.karpenkov added a comment.

>   To run just-built programs for tests. Not to run anything else

What? Why? 
How else can you run commands on the device (cat/cp/rm/etc) and why the semantics of those is different?
Many sanitizer tests already need those commands (e.g. this was recently done for libFuzzer to support device integration)

> most will have a shell anyway

Yes, and having a shell seems to be a basic requirement for running LIT tests anyway.

> I don't like forcing other platforms to do the same.

Where is this patch forcing other platforms?


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D51648





More information about the llvm-commits mailing list