[PATCH] D51618: [dsymutil] Reduce peak memory usage for the single threaded execution.

[Frederic Riss via Phabricator via llvm-commits]

friss added inline comments.


================
Comment at: llvm/tools/dsymutil/DwarfLinker.cpp:2552-2554
+    if (LinkContext.RelocMgr.hasValidRelocs() || LLVM_UNLIKELY(Options.Update))
+      DIECloner(*this, LinkContext.RelocMgr, DIEAlloc, LinkContext.CompileUnits,
+                Options)
----------------
Is that just a reformatting? Can you remove it from the patch if so?


================
Comment at: llvm/tools/dsymutil/DwarfLinker.cpp:2622-2625
+    for (unsigned i = 0, e = NumObjects; i != e; ++i) {
+      AnalyzeLambda(i);
+      CloneLambda(i);
+    }
----------------
This loop doesn't have the LinkContext.Objectfile check which was in CloneLambda before and is in CloneAll. Would it be cleaner to pass a LinkContext to the lambdas and leave the logic there?


https://reviews.llvm.org/D51618