[PATCH] D51643: [SampleFDO] Make sample profile loader unaware of compact format change

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 5 09:06:12 PDT 2018


davidxl added inline comments.


================
Comment at: include/llvm/ProfileData/SampleProf.h:461
+        GUIDToFuncNameMap.insert({Function::getGUID(OrigName), OrigName});
+        auto pos = OrigName.find('.');
+        if (pos != StringRef::npos) {
----------------
Add comments on this code about the substr mapping.


================
Comment at: test/Transforms/SampleProfile/Inputs/function_metadata.prof:1
-test:10000:0
+test:3200:0
+ 1: 100
----------------
why changing the profile data?


Repository:
  rL LLVM

https://reviews.llvm.org/D51643





More information about the llvm-commits mailing list