[PATCH] D51664: [IR] Lazily number instructions for local dominance queries

George Burgess IV via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 5 08:48:28 PDT 2018


george.burgess.iv added a comment.

I have zero context on the various ways we can/do add instructions to a BB, so I can't immediately be helpful with the tricky part of this review. :) I've no complaints about the general direction of this patch, though.

When the code's more polished, would it be reasonable to also stick a verifier of this somewhere (that we maybe just run per-query or per-pass on EXPENSIVE_CHECKS builds, or something)?


https://reviews.llvm.org/D51664





More information about the llvm-commits mailing list