[PATCH] D51582: [IndVars] Turn isValidRewrite into an assertion

[Andrew Trick via Phabricator via llvm-commits]

atrick accepted this revision.
atrick added a comment.
This revision is now accepted and ready to land.

> Is the "original test case" you are mentioning present somewhere in the unit tests? If no, I'd appreciate if you could check it in.

It looks like there was some proprietary C code that exposed this but never a reduced .ll test sadly. I'm positive that the original .c test no longer hits this assert, and think it's very unlikely that the current LLVM pipeline could still expose the issue. I'm just not sure exactly how SCEV itself guards against it.

I think it's fine for you to checkin this PR as-is, with the assert as a measure of safety.


https://reviews.llvm.org/D51582