[PATCH] D51625: [InstCombine] Add new tests in preparation for a combine of icmp (mul nsw/nuw X, C2), C

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM - the tests can be enhanced as we add/evolve the code for these folds.

I didn't look at all of the proofs, but at least for this pair, we can simplify the pre-conditions:
https://rise4fun.com/Alive/plgd

Also, for unsigned math, I think you want to use Alive's unsigned notation to match how the transforms will be coded:
https://rise4fun.com/Alive/nE9

Getting the pre-conditions right looks tricky, so I think it will be best to introduce the transforms for these 1 or 2 patterns at a time, so we can be sure we get each case right.


https://reviews.llvm.org/D51625