[PATCH] D51671: [ELF] Set Out::TlsPhdr earlier for encoding packed reloc tables

[Stephen Hines via Phabricator via llvm-commits]

srhines added inline comments.


================
Comment at: ELF/Writer.cpp:1654
+
+    for (PhdrEntry *P : Phdrs)
+      if (P->p_type == PT_TLS && P->FirstSec) {
----------------
rprichard wrote:
> srhines wrote:
> > const?
> We'd also have to make Out::TlsPhdr point to a const PhdrEntry. Do we want to do that? The rest of the section fields in InX and Out aren't const.
That should be decided by the main authors of LLD, but it seems like const would work fine on the declaration today for all of the existing uses.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D51671