[PATCH] D51612: [DebugInfo] Handle stack slot offsets for spilled sub-registers in LDV

[David Stenberg via Phabricator via llvm-commits]

dstenb added inline comments.


================
Comment at: lib/CodeGen/LiveDebugVariables.cpp:1222
+    Expr =
+        DIExpression::prepend(Expr, DIExpression::NoDeref, SpillOffset, Deref);
     IsIndirect = true;
----------------
dstenb wrote:
> aprantl wrote:
> > The DW_OP_deref is not already part of the expression if `Loc.wasIndirect()`?
> As far as I have understood it, the locations that are covered by "WasIndirect" are the indirect (reg+offset) DBG_VALUEs, which if they are not spilled are as the indirect DW_OP_*breg* operations, so they will not have a DW_OP_deref beforehand.
s/spilled are as/will be emitted as/


https://reviews.llvm.org/D51612