[PATCH] D51523: Return "[NFC] Add severe validation of InstructionPrecedenceTracking"

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 4 21:21:03 PDT 2018


mkazantsev updated this revision to Diff 163969.
mkazantsev added a comment.

After offline discussion with Philip, we agreed on the following version: by default, we have one-block verification to keep compile time in reasonable bounds. For troubleshooting purposes, there is an option (false by default and with no intention to turn it on) to diagnose it. Assertion on destructor does not happen because we don't have a commitment to keep the information valid after the last point where the last query was made.


https://reviews.llvm.org/D51523

Files:
  include/llvm/Analysis/InstructionPrecedenceTracking.h
  lib/Analysis/InstructionPrecedenceTracking.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51523.163969.patch
Type: text/x-patch
Size: 3485 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180905/3a65bbf7/attachment.bin>


More information about the llvm-commits mailing list