[PATCH] D50621: [DebugInfo] Fix bug in LiveDebugVariables.

[Hsiangkai Wang via Phabricator via llvm-commits]

HsiangKai added a comment.

In https://reviews.llvm.org/D50621#1222549, @bjope wrote:

> In https://reviews.llvm.org/D50621#1222530, @HsiangKai wrote:
>
> > @bjope: After I committed the patch to LLVM repo, it still failed in clang-ppc64be-linux-lnt buildbot.
> >
> > I guess the test case should contain target triple to be filtered out by llvm-lit in other architectures.
> >  Is it correct to add "target triple = 'x86_64-unknown-linux-gnu' " in the test case?
>
>
> That buildbot is probably building the compiler with support for both ppc and x86, but with ppc as default target.
>  So the check in test/DebugInfo/X86/lit.local.cfg that X86 is a configured target will pass, i.e. the test case will be executed even when the default target isn't X86.
>
> Without explicitly specifying the triple (either by a "target triple = ..." statement, or by using -mtriple in the RUN-line) the test case will be executed using the default target.
>
> In this case it might be slightly easier to add `-mtriple=x86_64-unknown-linux-gnu` to the RUN-line. Adding `target triple = 'x86_64-unknown-linux-gnu` should work as well, but then you need to put in inside the module definition (after line 10).


I got it. Thanks a lot. :)


Repository:
  rL LLVM

https://reviews.llvm.org/D50621