[PATCH] D51606: [XRay] Remove the deprecated __xray_log_init API

[Dean Michael Berris via Phabricator via llvm-commits]

dberris added inline comments.


================
Comment at: compiler-rt/include/xray/xray_log_interface.h:173
   /// See xray_interface.h for available handler installation routines.
-  XRayLogInitStatus (*log_init)(size_t, size_t, void *, size_t);
 
----------------
phosek wrote:
> dberris wrote:
> > This is an API+ABI change which we haven't communicated yet to users.
> > 
> > Please leave the interface as-is, update the comment that the first two arguments are no longer needed, and keep everything else as-is. We can tackle changing this at a later time, when we've had a chance to implement a replacement API to let users migrate to instead.
> Shall I keep `FDRLoggingOptions` and `BasicLoggingOptions` structs around as well or is it fine to remove those?
Please remove those along with `__xray_log_init(...)`. Thanks!


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D51606