[PATCH] D51662: [WebAssembly] Made assembler only use stack instruction tablegen defs

Jacob Gravelle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 4 16:10:48 PDT 2018


jgravelle-google added inline comments.


================
Comment at: utils/TableGen/AsmMatcherEmitter.cpp:1482
 
+  bool WebAssemblyTarget = Target.getName() == "WebAssembly";
+
----------------
nit: maybe `IsWebAssemblyTarget`? On first read I'd assumed that `WebAssemblyTarget` was the string "WebAssembly" and I was confused what `Target.getName()` was doing in this expression


Repository:
  rL LLVM

https://reviews.llvm.org/D51662





More information about the llvm-commits mailing list