[PATCH] D51652: lld-link: Write an empty "repro" debug directory entry if /Brepro is passed

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 4 15:42:07 PDT 2018


thakis added a comment.

Quoting from the PE spec (see bug for more): "The raw data of this debug entry may be empty". So I don't think it was a bug. Maybe tools had problems with the zero-sized entries, but they didn't bother to update the spec. So I'd suggest to go with this and only add more code if needed (?). We could add a size and just add the 4-byte hash to TimeDateStamps to fill it in at the end, but while it's easy to do it feels a bit cargo-culty.


https://reviews.llvm.org/D51652





More information about the llvm-commits mailing list