[PATCH] D51493: [llvm-strip] Allow copying relocation sections without symbol tables.

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 4 14:17:57 PDT 2018


rupprecht added a comment.

In https://reviews.llvm.org/D51493#1223877, @jakehehrlich wrote:

> When I run that yaml2obj test I actually get the following error rather than a silent failure.
>
> error: Unknown section referenced: '0' at YAML section '.rela.plt'.
>
> You might need to modify yaml2obj to test this or just convince me that this doesn't need testing. Alternatively you can upload a binary to the repo in Inputs that reproduces the issue.


I'm using yaml2obj from head -- maybe there's a recent change that fixed this?

  $ bin/yaml2obj ~/src/llvm/test/tools/llvm-objcopy/reloc-no-symtab.test | bin/llvm-readobj -sections | grep -A 10 .rela.plt
      Name: .rela.plt (16)
      Type: SHT_RELA (0x4)
      Flags [ (0x42)
        SHF_ALLOC (0x2)
        SHF_INFO_LINK (0x40)
      ]
      Address: 0x0
      Offset: 0x240
      Size: 0
      Link: 0
      Info: 4


Repository:
  rL LLVM

https://reviews.llvm.org/D51493





More information about the llvm-commits mailing list