[PATCH] D51525: [ADT] Add a new class OwnedOrBorrowed<T>

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 4 13:21:17 PDT 2018


dblaikie added a comment.

More or less agreed with @chandlerc (thanks for covering that all in detail) - though I'm marginally less concerned about the precedent setting in LLVM (small enough project we can rely a bit more on code review to discuss these things - and less likely to end up baked in so heavily that refactoring designs that are later discovered to be problematic to remove the use of this sort of thing).

I'd be interested to see the real code when it's out for review/committed & see what the options look like.


https://reviews.llvm.org/D51525





More information about the llvm-commits mailing list