[PATCH] D51652: lld-link: Write an empty "repro" debug directory entry if /Brepro is passed

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

> link.exe creates a zero-length repro debug directory entry with /debug /Brepro

Are you sure? That's not what I observed.

  /mnt/c/src/tmp$ cl.exe /c empty.cpp
  Microsoft (R) C/C++ Optimizing Compiler Version 19.15.26726 for x64
  Copyright (C) Microsoft Corporation.  All rights reserved.
  
  empty.cpp
  /mnt/c/src/tmp$ link.exe /Brepro empty.obj /noentry /dll
  Microsoft (R) Incremental Linker Version 14.15.26726.0
  Copyright (C) Microsoft Corporation.  All rights reserved.
  
  /mnt/c/src/tmp$ dumpbin.exe /all empty.dll | grep repro
      30663452 repro         24 00001064      264    9C 15 A8 DA BA 36 1C DE 3B E0 CE 53 07 D4 02 0A E3 D6 16 41 E5 7E A7 34 E9 17 82 13 52 34 66 30
  /mnt/c/src/tmp$ link.exe /Brepro empty.obj /noentry /dll /debug
  Microsoft (R) Incremental Linker Version 14.15.26726.0
  Copyright (C) Microsoft Corporation.  All rights reserved.
  
  /mnt/c/src/tmp$ dumpbin.exe /all empty.dll | grep repro
      BFF6ACB7 repro         24 000011A8      3A8    A3 53 C2 0E CD F8 2F 36 62 4C 68 4C 7E CB CB E2 29 8D E0 58 3D 59 59 79 B3 F1 AD 30 B7 AC F6 BF


https://reviews.llvm.org/D51652