[PATCH] D51048: cmake: Specify reference outputs in llvm_test_data()

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 4 12:04:36 PDT 2018


tra added a comment.

Your patch above *almost* works, except that each test variant wants to create the same symlink `$BUILD/ExternalCUDA/$TEST.teferece_output` -> `$SRC/External/CUDA/$TEST.reference_output`. If symlinks are created at different points in time ninja manages to avoid conflicts, but typically I get one or two attempts to create the symlink launches simultaneously and one of them fails with "symlink already exists". Perhaps the symlink target name should be uniquified in some way.


Repository:
  rT test-suite

https://reviews.llvm.org/D51048





More information about the llvm-commits mailing list