[PATCH] D51618: [dsymutil] Reduce peak memory usage for the single threaded execution.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 4 11:14:01 PDT 2018


aprantl added inline comments.


================
Comment at: llvm/tools/dsymutil/DwarfLinker.cpp:2618
+
+  // To limit memory consumption in the single threaded case we always analyze
+  // and clone together, so we can clear the LinkContext before moving on.
----------------
JDevlieghere wrote:
> aprantl wrote:
> > `... analyze and clone are run sequentially, so the LinkContext may be freed.`
> > where is this actually happening?
> We clear the context in endDebugObject.
The let's spell this out in the comment: `... analyze and clone are run sequentially, so the LinkContext is freed after processing each object in endDebugObject().`.


https://reviews.llvm.org/D51618





More information about the llvm-commits mailing list