[PATCH] D51603: [CMake] Provide a custom target to install LLVM libraries
Chris Bieneman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 4 11:09:16 PDT 2018
beanz added a comment.
One small comment below. Otherwise LGTM.
================
Comment at: llvm/CMakeLists.txt:986
endif()
+
+ # Custom target to install all libraries.
----------------
Should probably wrap this in `if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY)` because that variable gates generating the `install-${lib}` targets, so it will explode with missing targets if `LLVM_INSTALL_TOOLCHAIN_ONLY=On`.
Repository:
rL LLVM
https://reviews.llvm.org/D51603
More information about the llvm-commits
mailing list